Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPFD0-192] Fix rendering issues of NumberPad and CodeInput #149

Merged
merged 3 commits into from
Nov 27, 2023
Merged

[IOAPPFD0-192] Fix rendering issues of NumberPad and CodeInput #149

merged 3 commits into from
Nov 27, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Nov 27, 2023

Short description

This PR includes some fixes to NumberPad and CodeInput components.

List of changes proposed in this pull request

  • Remove gap property from CodeInput because it's not supported by RN 0.69
  • Remove flex property from NumberPad to avoid rendering issues in the main app
  • Remove legacy variant from NumberButton
  • Add a new value of app margin to the ContentWrapper

How to test

  1. Launch the example app
  2. Go to the Number Pad screen

@dmnplb dmnplb requested review from a team as code owners November 27, 2023 10:25
@dmnplb dmnplb merged commit afc8a22 into main Nov 27, 2023
2 checks passed
@dmnplb dmnplb deleted the IOAPPFD0-192-improvement-to-numberpad-codeinput branch November 27, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @CrisTofani