Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-226] Migrates ForceScrollDownViewPage from main app codebase #154

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[IOPLT-226] Migrates ForceScrollDownViewPage from main app codebase #154

merged 3 commits into from
Nov 28, 2023

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR includes the Scroll to bottom component from main app code

List of changes proposed in this pull request

  • ForceScrollDownView component

How to test

Check the related screen in example app

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners November 28, 2023 15:13
dmnplb
dmnplb requested changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, have you tried using ForceScrollDownViewPage with other custom ScrollView components? Or are they mutually exclusive?

src/components/layout/ForceScrollDownView.tsx Outdated Show resolved Hide resolved
@CrisTofani CrisTofani merged commit d0fed3d into main Nov 28, 2023
2 checks passed
@CrisTofani CrisTofani deleted the IOPLT-226 branch November 28, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisTofani @dmnplb