Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-272] Improve accessibility by adding accessibilityState to Button… components #234

Merged
merged 6 commits into from
Apr 8, 2024
Merged

[IOAPPX-272] Improve accessibility by adding accessibilityState to Button… components #234

merged 6 commits into from
Apr 8, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Mar 29, 2024

Short description

This PR adds the accessibilityState prop to all the Button… components

List of changes proposed in this pull request

  • Add accessibilityState

How to test

N/A

@dmnplb dmnplb added the a11y label Mar 29, 2024
@dmnplb dmnplb requested review from a team as code owners March 29, 2024 12:43
CrisTofani
CrisTofani requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestion on some code smells

src/components/buttons/ButtonOutline.tsx Show resolved Hide resolved
src/components/buttons/ButtonSolid.tsx Show resolved Hide resolved
@dmnplb dmnplb merged commit 6b4a1a7 into main Apr 8, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-272-add-accessibility-state-buttons branch April 8, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @CrisTofani