Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-293] Uniform spacing between list items, modules, and selection components #259

Merged
merged 4 commits into from
May 10, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented May 7, 2024

Short description

This PR unifies the spacing between different components: list items, modules, and selection components. This change was made to avoid alignment inconsistencies when using different components on the same screen.

List of changes proposed in this pull request

  • Update spacing in the ModuleCredential and ModuleNavigation components
  • Update spacing in all the ListItem… components
  • Update spacing in all the Selection… components
  • Update spacing in the Alert component

Preview

As you can see in the screenshot above, there was a different spacing between the ListItem... and Selection components (check the spacing between the icon and the text). This PR fixes that.

How to test

  1. Launch the example app
  2. Go to the relative pages: Modules, List Items, Selection and Alert

@dmnplb dmnplb requested review from a team as code owners May 7, 2024 12:24
@dmnplb dmnplb requested a review from mastro993 May 7, 2024 12:24
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 1f39aae into main May 10, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-293-uniform-spacing-list-items-toggle-modules branch May 10, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants