Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [PE-594] Remove marginLeft from ListItemNav chevron icon #260

Merged
merged 3 commits into from
May 9, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 9, 2024

Short description

This PR removes the static marginLeft from the ListItemNav chevron icon

List of changes proposed in this pull request

  • Removed the View that wraps the chevron icon removing the additional marginLeft

@Hantex9 Hantex9 requested review from dmnplb and a team as code owners May 9, 2024 10:51
@dmnplb
Copy link
Collaborator

dmnplb commented May 9, 2024

Just a note for future reference: we removed the space because the specific chevronRightListItem icon already has a space inside (on the left), so we don't need an additional margin.

@Hantex9 Hantex9 merged commit e437598 into main May 9, 2024
2 checks passed
@Hantex9 Hantex9 deleted the PE-594-remove-margin-list-item-nav-chevron branch May 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants