Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-294] Add activate and reactivate bleed pictograms #261

Merged
merged 1 commit into from
May 10, 2024
Merged

[IOAPPX-294] Add activate and reactivate bleed pictograms #261

merged 1 commit into from
May 10, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented May 10, 2024

Short description

This PR adds the bleed variant of the activate and reactivate pictograms

List of changes proposed in this pull request

  • Add new keys to the Pictogram component and relative subset
  • Update timestamp to fix the generateNewPictograms script
  • Fix end-of-line wrong character of some SVG to fix the script

Preview

Screenshot 2024-05-10 at 10 22 17

How to test

  1. Launch the example app
  2. Go to the Pictograms section

@dmnplb dmnplb requested a review from Vangaorth May 10, 2024 08:30
@dmnplb dmnplb requested review from a team as code owners May 10, 2024 08:30
Vangaorth
Vangaorth approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit f10a7e1 into main May 10, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-294-add-bleed-variant-pictograms branch May 10, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vangaorth Vangaorth Vangaorth approved these changes

Assignees
No one assigned
Labels
Foundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @Vangaorth