Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-305] Refine TextInputBase and TextInputValidation + Fix wrong visual appearance on Android #275

Merged
merged 25 commits into from
Jun 14, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented May 29, 2024

Short description

This PR refines TextInputBase and TextInputValidation and fixes a wrong visual appearance on Android.

List of changes proposed in this pull request

  • Refactor TextInputBase:
    • Include visual attributes at the top of the component
    • Change the way the borders are managed
    • Add a smooth transition between the initial state and the focused state using a simulated border to avoid jumps when the border width changes
    • Slightly improve UI performance, especially on Android devices
    • Add a gradient when the prop rightElement is set
  • Apply entering/exiting transition to the feedback icon in the TextInputValidation component
  • Add optional inputAccessoryViewID as prop for TextInput

Preview

Visual appearance of TextInputBase on Android devices before the fix

textInput-refinement-Android.mov

How to test

  1. Launch the example app
  2. Go to the Text Inputs screen

@dmnplb dmnplb requested review from a team as code owners May 29, 2024 13:13
@dmnplb dmnplb requested a review from CrisTofani May 29, 2024 13:14
Copy link
Member

@adelloste adelloste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Android physical device

@dmnplb dmnplb merged commit 48135b1 into main Jun 14, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-305-fix-textinput branch June 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants