chore: Add keepCancelVisible prop on SearchInput
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
approved these changes
Jun 14, 2024
adelloste
added a commit
to pagopa/io-app
that referenced
this pull request
Jun 17, 2024
…#5863) This PR depends on pagopa/io-app-design-system#289 ## Short description This PR sets `keepCancelVisible` prop to true on SearchInput component. <details open><summary>Details</summary> <p> | SearchInput | | - | | <video src="https://github.com/pagopa/io-app/assets/29163287/20838c71-f3b2-485a-b50f-205bfb7dd58d" width="300"/> | </p> </details> ## List of changes proposed in this pull request - bump `@pagopa/io-app-design-system` to 1.39.1 - set `keepCancelVisible` prop to true on SearchInput - set `keyboardDismissMode` prop to `interactive` for ios and `on-drag` as default ## How to test using `io-dev-api-server`, navigate to services search screen and check that the cancel button is always visible when input loses focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds
keepCancelVisibleprop on SearchInput component in order to keep the cancel button visible when the input loses focus.How to test