Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-333] Add dark mode support to all the Module… components #298

Merged
merged 18 commits into from
Jul 8, 2024
Merged

[IOAPPX-333] Add dark mode support to all the Module… components #298

merged 18 commits into from
Jul 8, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jun 25, 2024

Caution

This PR depends on:

Short description

This PR adds the dark mode support to all the Module… components

List of changes proposed in this pull request

  • Refactor code to apply theme keys to the color prop in the various typographic styles
  • Refactor code to use PressableModuleBase in all the components
  • Add the new ModuleStatic component to render the non-interactive version of the module. It can accept:
    • Two props: startBlock and endBlock
    • Single prop: children (standard mode)
  • Update some examples included in the Modules screen to test all the possible variants

Preview

dark-mode-modules.mp4

How to test

  1. Launch the example app
  2. Check the Modules screen, both in light and dark mode

dmnplb added 15 commits June 24, 2024 14:47
@dmnplb
Allow font scaling to most of the typographic styles
dc91c6c
@dmnplb
Fix criminal code without appropriate flexbox property
8874abc
@dmnplb
Add space between content and action in ModuleCheckout
f983653
@dmnplb
Add theme key to module border in the PressableModuleBase
0e7a970
@dmnplb
Allow font scaling to the remaining typographic styles
e712622
@dmnplb
Allow font scaling to ModuleIDP
ded1a0c
@dmnplb
Update jest snapshots
cc25300
@dmnplb
Trim text box in the Alert, based on dynamic font size
f6fdfe9
@dmnplb
Add space between title and amount in the ListItemAmount
65f0748
@dmnplb
Add loading example of ModulePaymentNotice
b53b493
@dmnplb
Add the new ModuleSkeleton, add it to two modules
24a231c
@dmnplb
Rename ModuleSkeleton into ModuleStatic
148422c
@dmnplb
Replace legacy code with ModuleStatic in the ModuleNavigation
7e94aa7
@dmnplb
Refactor ModuleAttachment to use PressableModuleBase
779b8a9
@dmnplb
Improve ModuleCheckout code
30a869f
@dmnplb dmnplb requested review from a team as code owners June 25, 2024 13:35
@dmnplb dmnplb mentioned this pull request Jul 5, 2024
Merged
mastro993
mastro993 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 883cb15 into main Jul 8, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-333-add-dark-mode-support branch July 8, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastro993 mastro993 mastro993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @mastro993