-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOAPPX-337] Refactor Modules…
and NumberPad
to take advantage of the new HStack
and VStack
components
#303
Merged
dmnplb
merged 20 commits into
main
from
IOAPPX-337-adopt-hstack-vstack-in-DS-components
Aug 26, 2024
Merged
[IOAPPX-337] Refactor Modules…
and NumberPad
to take advantage of the new HStack
and VStack
components
#303
dmnplb
merged 20 commits into
main
from
IOAPPX-337-adopt-hstack-vstack-in-DS-components
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This PR depends on the following PR. Do not merge the PR beforehand, otherwise it might break part of the UI.
Short description
This PR refactors
Modules…
andNumberPad
components to take advantage of the newHStack
andVStack
components.List of changes proposed in this pull request
NumberPad
andCodeInput
to replace the logic usingVSpacer
andHSpacer
Modules…
components (both interactive and skeleton states) usingHStack
andVStack
HStack
andVStack
to apply some specific style properties (alignItems
,flexShrink
, etc…)Related PRs
VStack
andHStack
components #241alignItems
prop toHStack
andVStack
components #297How to test