Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-337] Refactor Modules… and NumberPad to take advantage of the new HStack and VStack components #303

Merged
merged 20 commits into from
Aug 26, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jul 8, 2024

Caution

This PR depends on the following PR. Do not merge the PR beforehand, otherwise it might break part of the UI.

Short description

This PR refactors Modules… and NumberPad components to take advantage of the new HStack and VStack components.

List of changes proposed in this pull request

  • Update NumberPad and CodeInput to replace the logic using VSpacer and HSpacer
  • Update all the Modules… components (both interactive and skeleton states) using HStack and VStack
  • Refactor HStack and VStack to apply some specific style properties (alignItems, flexShrink, etc…)

Related PRs

How to test

  1. Launch the example app
  2. First, check Numberpad screen
  3. Second, check Modules screen

@dmnplb dmnplb requested review from a team as code owners July 8, 2024 15:52
@dmnplb dmnplb merged commit d719af8 into main Aug 26, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-337-adopt-hstack-vstack-in-DS-components branch August 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants