Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPID-2068] OTPInput accessibility improvements #315

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[IOPID-2068] OTPInput accessibility improvements #315

merged 3 commits into from
Jul 30, 2024

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Jul 25, 2024 •
edited
Loading

Short description

Announce the pressed keys to the screen reader

List of changes proposed in this pull request

  • Add deleteButtonAccessibilityLabel prop to the OTPInput component
  • Announce keyboard pressed keys to the screen reader

Demo

A11Y
iOS Android
iOS-a11y-cie-keyboard-feedback.mov
android-a11y-cie-keyboard-feedback.mp4

@ChrisMattew ChrisMattew self-assigned this Jul 25, 2024
@ChrisMattew ChrisMattew marked this pull request as ready for review July 29, 2024 12:26
@ChrisMattew ChrisMattew requested review from dmnplb and a team as code owners July 29, 2024 12:26
@dmnplb dmnplb merged commit ef324ae into main Jul 30, 2024
6 checks passed
@dmnplb dmnplb deleted the IOPID-2068-otp-input-a11y branch July 30, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

@shadowsheep1 shadowsheep1 Awaiting requested review from shadowsheep1

@Ladirico Ladirico Awaiting requested review from Ladirico

Assignees

@ChrisMattew ChrisMattew

Labels
a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisMattew @dmnplb