[IOPID-2107] Adjust TextInput accessibility behavior #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iOS' VoiceOver to access the input element
dmnplb
approved these changes
Aug 27, 2024
Ladirico
added a commit
to pagopa/io-app
that referenced
this pull request
Sep 3, 2024
…on screen (#6117) ## Short description Fixed some accessibility bugs, updated snapshots and updated `react-native-reanimated` config in `jestConfig.js` file. ## List of changes proposed in this pull request - Upgrade DS lib version, more infos [here](pagopa/io-app-design-system#326) - Fixed the focus behavior on keyboard key press - Updated snapshots - Updated `jestConfig.js` file ## E2E >[!Tip] >[](https://github.com/pagopa/io-app/actions/workflows/test-e2e.yml) ## Demo <details> <summary>A11Y iOS</summary> |Before |Announce Error|Keypress Focus| |-------|-----|------| |<video src="https://github.com/user-attachments/assets/b70688e6-30c4-427c-8878-94f0f5abf667" />|<video src="https://github.com/user-attachments/assets/98fec96e-4fe7-4c26-b692-365b8e37b1e2" />|<video src="https://github.com/user-attachments/assets/60f97355-020f-42e2-a08d-393eb21ccc09" />| </details> <details> <summary>A11Y Android</summary> |Before |Announce Error|Keypress Focus| |-------|-----|------| |<video src="https://github.com/user-attachments/assets/279dabcb-30d9-49bb-8329-1f53a85128bc" />|<video src="https://github.com/user-attachments/assets/43fb36ed-6601-4f14-8c8e-883fdb0b24d3" />|<video src="https://github.com/user-attachments/assets/6267289e-dc42-4517-99b5-a7391ef91dc3" />| </details> ## How to test Using a physical device, enable the screen reader and interact with the `EmailInsertScreen`. --------- Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
](https://github.com/pagopa/io-app/actions/workflows/test-e2e.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Removed
accessibilityElementsHiddenprop to allow iOS' VoiceOver to access Input elementList of changes proposed in this pull request
accessibilityElementsHiddenpropDemo
A11Y iOS
iOS-a11y-email-insertion-input-focus.mov
iOS-a11y-email-insertion-fix.mov
How to test
Run the application from an iOS physical device with VoiceOver enabled and try to target a
TextInputBaseelement.