Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-408] Fix alignment of Alert icon when there's a line of content #338

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Oct 21, 2024

Short description

This PR fixes the alignment of Alert icon when there's just a line of content

List of changes proposed in this pull request

  • Add onTextLayout event to count the lines and apply different style based on context

Preview

Before After
alert-oneline-before alert-oneline-after

How to test

  1. Launch the example app
  2. Go to the Alert page and check if everything is OK

@dmnplb dmnplb added the bug Something isn't working label Oct 21, 2024
@dmnplb dmnplb requested review from a team as code owners October 21, 2024 12:27
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 0309dcc into main Oct 29, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-408-fix-alert-alignment-one-line branch October 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants