Add granular support for allowFontScaling to the IOText component
#347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
approved these changes
Nov 8, 2024
dmnplb
deleted the
IOAPPX-416-add-granular-support-for-dynamic-text-size
branch
dmnplb
added a commit
that referenced
this pull request
Dec 16, 2024
…ts based on the value of `fontScale` (#348) >[!caution] > This PR depends on the following PR: > * #347 ## Short description This PR adds a dynamic size to some components, based on the value of `fontScale`. Dynamic size is currently supported on the following components: - `Tag`, `Badge`, `Alert` and `FeatureInfo` - All the selection components (`ListItemCheckbox`, `ListItemRadio`, etc…) - All the `ListItem…` components ## List of changes proposed in this pull request - Add the new `useIOFontDynamicScale` hook to get the current `fontScale` value - Add the new `allowFontScaling` to `Icon`, `AnimatedIcon` and `Pictogram` components to enable dynamic size based on the `fontScale` value - Add the new `allowScaleSpacing` to `Stack` components to enable the same behavior - Add dynamic spacing to `Tag`, `Badge`, all the selection and `ListItem…` components - Increase value of the `maxFontSizeMultiplier` from `1.25` to `1.5` - Hide decorative icons from `ListItem…` and `Module…` components if the text size multiplier is quite big (>= 1.5) ### Preview #### `ListItemCheckbox` As you can see, the size of the margins, icons and checkboxes also changes depending on the value of `fontScale`: | Default size | Larger text size | |--------|--------| |  |  | #### `Alert` Same as above, but with boldEnabled set to _ON._ | Default size | Larger text size | |--------|--------| |  |  | ## How to test 1. Launch the example app 2. Go to the **Accessibility → Display & Text Size → Larger text** 3. Change the values 4. Go back to the example app to see the applied changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds granular support for the
allowFontScalingandmaxFontSizeMultiplierprops to theIOTextcomponent. This change alone allows the developer to override these values in the single instance instead of all instances.List of changes proposed in this pull request
IOTextfor the mentioned propsHow to test
Try forcing
allowFontScalingon the typographic styles, even with the experimental DS turned off.