[IOAPPX-435] Improve typography by standardising sizes and removing redundant styles #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
approved these changes
Nov 20, 2024
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
Dec 5, 2024
…-app-design-system` to `4.0.1` (#6422) ## Short description This PR improves overall UI typography. ## List of changes proposed in this pull request - Update `io-app-design-system` to the new major `4.0.1` version - Update font weight in the `HeaderFirstLevel` to make the title bolder - Improve **Strong** markdown style by replacing `Bold` with the `Semibold` style - Decrease font weight of the subtitle in the `ServicesHeader` component - Improve formatting of the `MessageListItem` - Replace removed `Chip` typographic style with `LabelMini` - Replace removed `Label` typographic style with `Body` - Replace removed `LabelSmall` typographic style with the new `BodySmall` - **[extra]** Fix typo in the English locale (`CIEIdWizard`) > [!note] > **For the reviewers:** the default weight of `LabelSmall` was `Semibold`, while the default weight for `BodySmall` is `Regular`. That's why `LabelSmall` set without the `weight` prop was replaced by `BodySmall` with the `weight` prop set to `Semibold`. The same should happen to the `Label` typographic style ### Preview | Actual UI | New UI | |--------|--------| |  |  | #### Old vs New <details><summary><code>Messages Home</code></summary> <p> | Before | After | |--------|--------| |  |  | </p> </details> <details><summary><code>Payments Home</code></summary> <p> | Before | After | |--------|--------| |  |  | </p> </details> ### Related PRs * pagopa/io-app-design-system#360 * pagopa/io-app-design-system#361 ## How to test Check each DS component and navigate through the app to check if everything is OK --------- Co-authored-by: Emanuele Dall'Ara <71103219+LeleDallas@users.noreply.github.com> Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This PR introduces breaking changes
Short description
This PR improves typography by standardising sizes and removing redundant styles.
List of changes proposed in this pull request
Button…componentsH6(experimental variant)ModuleNavigationwith correct line heightLabelSmalltoBodySmallChipandLabeltypographic style (replaced withLabelMiniandBodyrespectively)BaseTypographyandFactoryBoldweight fromBodyandLabel…stylesBoldweight toH3for theHeaderFirstLevelcomponentBodywithBodySmallin theFeatureInfocomponentHow to test
Check each component in the DS