Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-441] Uniform text sizes of ListItem… components #363

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Nov 28, 2024

Short description

This PR unifies the text sizes of the ListItem... components. In particular, it increases the text sizes of ListItemRadioWithAmount and ListItemTransaction which were smaller.

List of changes proposed in this pull request

  • Increase the text sizes of the title in both ListItemRadioWithAmount and ListItemTransaction components
  • Refactor them using HStack instead of VSpacer
  • Reduce the size of the old H6 style to make the transition between the old and new UI less dramatic
  • [extra] Fix overflow text in the ListItemAction

Preview

Before After
Simulator Screenshot - iPhone 16 Pro - 2024-11-28 at 11 05 25 Simulator Screenshot - iPhone 16 Pro - 2024-11-28 at 10 49 48

How to test

Go to the List Items screen in the example app and scroll until the end of the page

@dmnplb dmnplb marked this pull request as ready for review November 28, 2024 10:14
@dmnplb dmnplb requested review from a team as code owners November 28, 2024 10:14
@LeleDallas
Copy link
Contributor

PR 441 Main
Screen.Recording.2024-12-05.at.19.28.58.mov
Screen.Recording.2024-12-05.at.19.28.29.mov

Seems good to me!

@dmnplb dmnplb merged commit adf19d3 into main Dec 5, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-441-make-list-item-text-sizes-uniform branch December 5, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants