Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-126] Adds the missing Typography components #48

Merged
merged 19 commits into from
Sep 14, 2023
Merged

[IOPLT-126] Adds the missing Typography components #48

merged 19 commits into from
Sep 14, 2023

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Aug 22, 2023 •
edited
Loading

Short description

This PR implements missing typography components

How to test

Check on sample app

@CrisTofani CrisTofani changed the title Adds the missing Typography components [IOPLT-1260] Adds the missing Typography components Aug 22, 2023
@CrisTofani CrisTofani marked this pull request as ready for review August 22, 2023 14:03
@CrisTofani CrisTofani requested review from dmnplb and a team as code owners August 22, 2023 14:03
@CrisTofani CrisTofani changed the title [IOPLT-1260] Adds the missing Typography components [IOPLT-126] Adds the missing Typography components Aug 23, 2023
@dmnplb
Copy link
Collaborator

dmnplb commented Aug 24, 2023 •
edited
Loading

  • Updated some wrong typographic values, compared to the design guidelines
  • Removed some AllowedColors that don't belong to some typographic styles
  • Renamed CTA into ButtonText because it's more clear when used in the Button… components
  • Renamed Monospace into BodyMonospace, according to the design guidelines
  • Updated ButtonSolid to use ButtonText style instead of custom style
  • Removed some legacy styles from Button… components
  • Updated Typography page in the example app

@CrisTofani Please check them out

CrisTofani
CrisTofani commented Aug 24, 2023
View reviewed changes
Copy link
Contributor Author

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmnplb some weights were missing from latest deletes are these ok for you?

src/components/typography/H2.tsx Show resolved Hide resolved
src/components/typography/H3.tsx Show resolved Hide resolved
@dmnplb dmnplb mentioned this pull request Aug 25, 2023
Merged
@CrisTofani CrisTofani marked this pull request as draft August 29, 2023 09:08
@CrisTofani CrisTofani marked this pull request as ready for review August 29, 2023 09:09
@mastro993
Copy link
Contributor

  • Updated some wrong typographic values, compared to the design guidelines
  • Removed some AllowedColors that don't belong to some typographic styles
  • Renamed CTA into ButtonText because it's more clear when used in the Button… components
  • Renamed Monospace into BodyMonospace, according to the design guidelines
  • Updated ButtonSolid to use ButtonText style instead of custom style
  • Removed some legacy styles from Button… components
  • Updated Typography page in the example app

@CrisTofani Please check them out

CTA typography is also used in Toast Notifications: https://www.figma.com/file/4Pbt3wd9WoPnAXVMkAA6UT/App-IO-2.0---Design-System?type=design&node-id=6193-25828&mode=design&t=nxPyGhQ02VmJ1rSo-4

@CrisTofani CrisTofani merged commit ec8561b into main Sep 14, 2023
@CrisTofani CrisTofani deleted the IOPLT-126O-typography-component branch September 14, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrisTofani @dmnplb @mastro993