[IOAPPFD0-144] Add the new IconContained component
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the new
IconContained, a component designed to render an icon inside a circle. Inspired by Google Material Icon Button's various contained styles, the component takes two props besidesicon:variantandcolor. The default and unique values, for now, aretonal(variant) andneutral(color).Warning
IconContainedis just a special wrapper for theIconcomponent. It's also not an interactive component, unlike the Google Material'sIconButton. When adding new styles, you should be aware of this context and be careful not to add variants that look like interactive counterparts.List of changes proposed in this pull request
IconContainedcomponenttransactionsiconPreview
How to test
Go to the Icons (Foundation) in the example app.