Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-241] Add IconChange and IconDialpad icons #67

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Sep 14, 2023

Short description

This PR adds two new icons: IconChange and IconDialpad used inside this bottom sheet page.

List of changes proposed in this pull request

  • Added svgs original files and react components

Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a minor issue (I should probably add it to the local README about adding new icons), but to facilitate the fruition of the icons in the DS Icons page, we should add the icons near the conceptually similar ones. In this case the change key should be grouped with other arrow icons. Also dialpad near the device icon.

It's not mandatory, but it's nice to have.

(To check the order, just launch the example app to quickly look at the page)

@Hantex9
Copy link
Contributor Author

Hantex9 commented Sep 14, 2023

I know it's a minor issue (I should probably add it to the local README about adding new icons), but to facilitate the fruition of the icons in the DS Icons page, we should add the icons near the conceptually similar ones. In this case the change key should be grouped with other arrow icons. Also dialpad near the device icon.

It's not mandatory, but it's nice to have.

(To check the order, just launch the example app to quickly look at the page)

I agree with you about keeping icons grouped together! Addressed into 21e63c4

@Hantex9 Hantex9 merged commit 6517f1b into main Sep 15, 2023
@Hantex9 Hantex9 deleted the IOBP-241-add-new-icon-change-and-dialpad branch September 15, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants