Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-223] Import new keyboard and contactless icons #73

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Sep 18, 2023

Short description

This PR adds assets and component icons for the new keyboard and contactless icons

List of changes proposed in this pull request

  • Added original svg files and react components;
  • Mapped keyboard and contactless icons into Icon.tsx file;

How to test

Open the example app and check if there are these two new icons

Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard icon already exists as a dialpad icon. Check if it changes or if it's ok for you. Nothing to say about the contactless one.

@Hantex9
Copy link
Contributor Author

Hantex9 commented Sep 18, 2023

The keyboard icon already exists as a dialpad icon. Check if it changes or if it's ok for you. Nothing to say about the contactless one.

To be compliant to the Design System on Figma i removed the dialpad icon and left the new keyboard one. Designers changed the name of it in a second time.

Addressed in e9dccc5 and 14b4150

@Hantex9 Hantex9 requested a review from dmnplb September 18, 2023 07:53
@Hantex9 Hantex9 merged commit fbf666c into main Sep 18, 2023
@Hantex9 Hantex9 deleted the IOBP-223-new-icons-contactless branch September 18, 2023 07:56
Hantex9 added a commit to pagopa/io-app that referenced this pull request Sep 27, 2023
## ⚠️ This PR depends on
pagopa/io-app-design-system#73 and #4990

## Short description
This PR adds a custom hook `useIdPayInfoCieBottomSheet` designed to
display a bottom sheet containing detailed information about how the CIE
payment authorization works for a discount initiative.

## Design reference

[FIGMA](https://www.figma.com/file/SuYjyjZlieQqRS8n1B6qbF/Flussi-App-ID-Pay?type=design&node-id=9611-30793&mode=design&t=mqcM2GWOFRs4RGrR-4)

## List of changes proposed in this pull request
- Created a new custom hook `useIdPayInfoCieBottomSheet` with the basic
`FeatureInfo` components
- Upgraded `@pagopa/io-app-design-system` library

## How to test
Actually this is only the definition of the bottomsheet UI, the hook is
still not used anywhere but you can try yourself by invoking the
`present` method of this custom hook and check the UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants