Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-135] Refinement of the HeaderSecondLevel Component #77

Merged
merged 13 commits into from
Sep 26, 2023

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR refines the component definition of the Header of the second level navigation pages.

How to test

Check the related Header Second Level example app page to verify everything's fine

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners September 20, 2023 16:01
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to include an example of the 2nd level header without animation? Also to understand how it behaves without adding a ScrollView with triggerOffsetValue?

@CrisTofani CrisTofani merged commit 12e6f1f into main Sep 26, 2023
2 checks passed
@CrisTofani CrisTofani deleted the IOPLT-135-header-second-level-refine branch September 26, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants