Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-138] Creates the new ModulePaymentNotice #78

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Sep 21, 2023

Short description

This PR introduces the new ModulePaymentNotice in the library components

List of changes proposed in this pull request

  • new ModulePaymentNotice component

How to test

Check the related Section in the Modules screen of the example app

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners September 21, 2023 15:00
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed a couple of visual inconsistencies with the experimental DS set to "on", especially when compared to the design artboards that came with it:

  • The arrow icon has the old blue instead of the new one.
  • The title of the payment notice is set with Titilium, instead of Readex.

@CrisTofani
Copy link
Contributor Author

  • The title of the payment notice is set with Titilium, instead of Readex.

@dmnplb Title is rendered through LabelSmall component which has no ReadexPro variant in the new DS components (or we missed to implement it) do you have any other suggested component to use in this case?

@dmnplb
Copy link
Collaborator

dmnplb commented Sep 25, 2023

Title is rendered through LabelSmall component which has no ReadexPro variant in the new DS components (or we missed to implement it) do you have any other suggested component to use in this case?

We probably could use the opportunity to add the missing typographic style (that's transformed to Titilium with DS set to off). What do you think?

@CrisTofani CrisTofani requested a review from dmnplb September 25, 2023 13:36
@CrisTofani CrisTofani merged commit 0e337ce into main Sep 25, 2023
@CrisTofani CrisTofani deleted the IOPLT-138 branch September 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants