Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPFD0-154] Fix UI regressions affecting Button… and LabelLink components #80

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Sep 22, 2023

Short description

This PR fixes the following visual regressions:

  • LabelLink component: it didn't have the correct color when experimental DS was off
  • Legacy style of the ButtonSolid contrast variant: it used the blueIO colour instead of the classic blue
  • Both ButtonSolid and ButtonOutline had wrong icon sizes (too big for the legacy variant)

How to test

N/A

@dmnplb dmnplb added the bug Something isn't working label Sep 22, 2023
@dmnplb dmnplb requested review from a team as code owners September 22, 2023 13:10
@dmnplb dmnplb changed the title [IOAPPFD0-154] Fix UI regressions affecting Buttons... and LabelLink components [IOAPPFD0-154] Fix UI regressions affecting Buttons… and LabelLink components Sep 22, 2023
@dmnplb dmnplb changed the title [IOAPPFD0-154] Fix UI regressions affecting Buttons… and LabelLink components [IOAPPFD0-154] Fix UI regressions affecting Button… and LabelLink components Sep 22, 2023
@dmnplb dmnplb merged commit b530ce0 into main Sep 22, 2023
@dmnplb dmnplb deleted the IOAPPFD0-154-fix-buttons-and-label-link branch September 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants