Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPFD0-155] Add color mode support to all the pictograms #82

Merged
merged 9 commits into from
Sep 25, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Sep 25, 2023

Short description

This PR adds support for color mode to all the new pictograms available (except legacy ones)

List of changes proposed in this pull request

  • Add color mode support to all the pictograms
  • Add the new pictogramStyle property:
    • default: the pictogram changes colours based on the enabled system color mode (dark or light).
    • light-content: the pictogram keeps light colours, regardless of the system color mode. It must be used on dark backgrounds.
    • dark-content: the pictogram keeps dark colours, regardless of the system color mode. It must be used on light backgrounds.
  • Add the pictogramStyle = "dark-content" prop to the pictograms used in the Banner component
  • Add two new pictograms, with relative bleed variants:
    • cameraRequest (updated)
    • cameraDenied

Preview

dark-mode-pictograms.mp4

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@dmnplb dmnplb added the Assets label Sep 25, 2023
@dmnplb dmnplb requested review from a team as code owners September 25, 2023 15:04
@dmnplb dmnplb merged commit eb34ac3 into main Sep 25, 2023
@dmnplb dmnplb deleted the IOAPPFD0-155-dark-mode-pictograms branch September 25, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants