-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-448] Add missing components to the Design System section, remove legacy ones + Change ListItemMessage
component API
#6541
Open
dmnplb
wants to merge
28
commits into
master
Choose a base branch
from
IOAPPX-448-update-ds-documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,263
−1,161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
New visual language and reduction of previous UI clutter
label
Dec 11, 2024
pagopa-github-bot
changed the title
[IOAPPX-448] Add missing components to the Design System section
chore(Cross): [IOAPPX-448] Add missing components to the Design System section
Dec 11, 2024
Affected stories
|
dmnplb
changed the title
chore(Cross): [IOAPPX-448] Add missing components to the Design System section
chore(Cross): [IOAPPX-448] Add missing components to the Design System section, remove legacy ones
Dec 13, 2024
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
December 13, 2024 15:12
Hantex9
reviewed
Dec 17, 2024
Hantex9
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR updates the Design System section with missing components. Checking them in isolation is essential to avoid regression during development.
List of changes proposed in this pull request
BannerErrorState
to theDSAdvice
pageListItemSearchInstitution
to theDSListItems
pageCgnModuleDiscount
toModuleCgnDiscount
, refactor it and move it toDSModules
fromDSListItems
DSColors
because CGN doesn't use them anymoreMessageListItem
→ListItemMessage
DoubleAvatar
toAvatarDouble
(to keep the same convention as the others) and add it to theDSLogos
pagebadgeText
andbadgeVariant
props with the singletag
propCustomPressableListItemBase
by integrating it intoListItemMessage
ListItemMessage
possible combinations toDSListItems
for testing purposesPreview
The new
ListItemMessage
section in the List Items pageHow to test
Go to the Design System section and check the update pages