feat: [IOCOM-435] Add polling for download F24 attachments #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5149 +/- ##
==========================================
- Coverage 47.77% 47.76% -0.02%
==========================================
Files 1534 1535 +1
Lines 31631 31645 +14
Branches 7873 7875 +2
==========================================
+ Hits 15112 15115 +3
- Misses 16463 16474 +11
Partials 56 56
Continue to review full report in Codecov by Sentry.
|
Vangaorth
requested changes
Oct 25, 2023
|
🎉 All dependencies have been resolved ! |
adelloste
added a commit
that referenced
this pull request
Oct 27, 2023
> [!warning] > This PR depends on #5149 ## Short description This PR adds support for F24 section on SEND message screen. If we have only one F24, it is rendered in the detail of the message otherwise the "Vedi modelli F24" button is rendered. ### Preview | === 1 | > 1 | | --- | --- | | <img src="https://github.com/pagopa/io-app/assets/29163287/916e080a-0012-4a2b-b2b9-f50dbb4edc82" width="300" /> | <img src="https://github.com/pagopa/io-app/assets/29163287/67876ced-7014-44e7-af78-5854af79e43e" width="300" /> | ## List of changes proposed in this pull request - Added F24 section - Added the new component `MessageAttachments` - Marked as legacy the old component `MessageAttachments` - Updated langs ## How to test Generate a SEND message with F24 attachemts using `io-dev-api-server`. Check that F24 section is displayed correctly. --------- Co-authored-by: Andrea <andrea.piai@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds polling for download F24 attachments.
When the app requests the download of an F24 attachment, if the backend responds with a 503 code with the retry-after header value set, the app will wait for the time specified in the header before making the next request.
Preview
Registrazione.schermo.2023-10-20.alle.15.12.06.mov
List of changes proposed in this pull request
How to test
Generate a generic message with attachments and a PN message with attachments and F24 using
io-dev-api-server.In case of a 503 and retry-after, check that the requests are handled correctly: the app should wait for n seconds before making the next request