-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOPAE-1100,IOPAE-1282,IOPAE-1285] Remove old implementation of services #5898
Conversation
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5898 +/- ##
==========================================
+ Coverage 48.42% 49.37% +0.94%
==========================================
Files 1488 1706 +218
Lines 31617 33905 +2288
Branches 7669 8091 +422
==========================================
+ Hits 15311 16739 +1428
- Misses 16238 17111 +873
+ Partials 68 55 -13
... and 844 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there are two related components that should also be deleted:
SectionHeaderComponent
services/OrganizationLogo
Also, completely off topic, there's the local TabNavigation
, which has already been replaced by the new one referenced by io-app-design-system
. It should be deleted as well.
If you agree, let's delete them in this PR 💪🏻
Applied suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR removes the old implementation of services
List of changes proposed in this pull request
DSGradientScroll
componentTabNavigation
componentHow to test
Navigate through the app and check that everything is working properly