Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPAE-1100,IOPAE-1282,IOPAE-1285] Remove old implementation of services #5898

Merged
merged 18 commits into from
Jul 8, 2024

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented Jun 25, 2024

Short description

This PR removes the old implementation of services

List of changes proposed in this pull request

  • Removed unused services related files
  • Added migration to remove the persistence of service data in entities
  • Removed unused translation keys
  • Removed DSGradientScroll component
  • Removed TabNavigation component

How to test

Navigate through the app and check that everything is working properly

@adelloste adelloste added the IO-Enti e Servizi IO - Enti e Servizi label Jun 25, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1100,IOPAE-1282,IOPAE-1285] Remove old implementation of services chore: [IOPAE-1100,IOPAE-1282,IOPAE-1285] Remove old implementation of services Jun 25, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jun 25, 2024

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • ⚙️ IOPAE-1100: [APP] Eliminare il codice legacy della sezione servizi
    subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)
  • ⚙️ IOPAE-1282: [APP] Spostare store preferenze del servizio sotto features/services/details
    subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)
  • ⚙️ IOPAE-1285: [APP] Spostare store dettagli dei servizi sotto features/services/details
    subtask of
    • IOPAE-645: Redesign sezione servizi (PNRR 31.12.2024)

Generated by 🚫 dangerJS against 6d957fa

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (4f204b4) to head (6d957fa).
Report is 251 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5898      +/-   ##
==========================================
+ Coverage   48.42%   49.37%   +0.94%     
==========================================
  Files        1488     1706     +218     
  Lines       31617    33905    +2288     
  Branches     7669     8091     +422     
==========================================
+ Hits        15311    16739    +1428     
- Misses      16238    17111     +873     
+ Partials       68       55      -13     
Files Coverage Δ
ts/components/screens/BadgeComponent.tsx 66.66% <ø> (ø)
ts/components/search/SearchButton.tsx 5.40% <ø> (+0.52%) ⬆️
ts/config.ts 100.00% <ø> (ø)
...s/cgn/screens/merchants/CgnMerchantsTabsScreen.tsx 33.33% <ø> (-1.97%) ⬇️
ts/features/bonus/common/store/selectors/index.ts 92.30% <ø> (ø)
...features/design-system/core/DSLegacyPictograms.tsx 40.00% <ø> (-10.00%) ⬇️
ts/features/fci/hooks/useFciCheckService.tsx 43.47% <100.00%> (ø)
...eatures/fci/screens/valid/FciQtspClausesScreen.tsx 71.11% <100.00%> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 14.28% <ø> (ø)
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 8.69% <ø> (-7.98%) ⬇️
... and 36 more

... and 844 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153b621...6d957fa. Read the comment docs.

@adelloste adelloste marked this pull request as ready for review July 4, 2024 14:17
@adelloste adelloste requested a review from dmnplb as a code owner July 4, 2024 14:17
Copy link
Contributor

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there are two related components that should also be deleted:

  • SectionHeaderComponent
  • services/OrganizationLogo

Also, completely off topic, there's the local TabNavigation, which has already been replaced by the new one referenced by io-app-design-system. It should be deleted as well.

If you agree, let's delete them in this PR 💪🏻

@adelloste
Copy link
Member Author

Apparently there are two related components that should also be deleted:

  • SectionHeaderComponent
  • services/OrganizationLogo

Also, completely off topic, there's the local TabNavigation, which has already been replaced by the new one referenced by io-app-design-system. It should be deleted as well.

If you agree, let's delete them in this PR 💪🏻

Applied suggestions

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit 03a24e6 into master Jul 8, 2024
13 checks passed
@adelloste adelloste deleted the IOPAE-1100-1282-1285 branch July 8, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Enti e Servizi IO - Enti e Servizi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants