feat: [IOCOM-1413] Archiving/Restoring of user messages, new Messages Home #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ts/features/messages/components/Home/WrappedMessageListItem.tsx
…o-app into IOCOM-840_preconditions
# Conflicts: # ts/features/messages/screens/MessagesHomeScreen.tsx
forrest57
reviewed
Jul 9, 2024
forrest57
reviewed
Jul 9, 2024
ts/features/messages/saga/handleUpsertMessageStatusAttributes.ts
Outdated
Show resolved
Hide resolved
forrest57
reviewed
Jul 9, 2024
forrest57
reviewed
Jul 9, 2024
forrest57
reviewed
Jul 9, 2024
| @@ -122,6 +124,17 @@ export function* handlePendingMessageStateIfAllowedSaga( | |||
| yield* call(navigateToMainNavigatorAction); | |||
| } | |||
|
|
|||
| // It the archiving/restoring of messages is not disable, make | |||
There was a problem hiding this comment.
Suggested change
| // It the archiving/restoring of messages is not disable, make | |
| // If the archiving/restoring of messages is not disabled, make |
small typo ;p
forrest57
approved these changes
Jul 9, 2024
Vangaorth
added a commit
that referenced
this pull request
Jul 15, 2024
⚠️ This PR depends on #5935⚠️ ## Short description This PR implements the new messages local search. |iOS<br/>Soft keyboard|Android<br/>Hardware keyboard| |-|-| |<video src="https://github.com/pagopa/io-app/assets/5150343/732e7561-9b81-4f6e-85b4-20a352625f70"/>|<video src="https://github.com/pagopa/io-app/assets/5150343/a886421f-3cb1-48ef-989c-2eed645b5139"/>| **_Please note_** that the extra horizontal padding (on list items and dividers) shown in the video above has been removed. ## List of changes proposed in this pull request - New screen with messages search - New cached selector for message search ## How to test Using the io-dev-api-server, generate some messages, make sure to enable the new DS and the new Messages Home and tap the search lens. --------- Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the support for archiving and restoring of user messages, in the new messages home.
AR_iOS.mp4
AR_android.mov
Please note that the toast showing "Annullato" has been removed.
List of changes proposed in this pull request
New archiving/restoring UI and UX. In order to both fix previous problems and not change a complex business logic, this PR builds above the latter, keeping the compatibility with the old system (the algorithm is explained in
ts/features/messages/saga/handleUpsertMessageStatusAttributes.ts)Messages are enqueued by Id while in the "enabled" state and processed one at a time while in "processing" state, in order to properly handle whatever failure may happen. It also supports cancellation by the user. If at any moment an error or a cancellation happens, the processing is suspended, the user is notified but she can later resume it.
ArchiveRestoreBaris the component that displays the bottom CTAs for archiving/restoringSince the bottom bar is hidden while picking messages or processing them, there are some application entry points that have been disabled, in order not to trigger a flow that may later bring back to another main screen without the bottom bar. Such flows are deep link following, push notification tapping, message reloading and next page loading during processing, first message page loading and message search.
How to test
Using the io-dev-api-server, make sure to enable both DS and new messages home. Long tap (and later tap) on some messages and try the archiving/restoring/cancelling.