-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-346] Remove manually linked deps #5972
Open
LazyAfternoons
wants to merge
292
commits into
master
Choose a base branch
from
IOAPPX-346-remove-autolinked-deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 413bb3f.
…T-342-react-native-upgrade
LazyAfternoons
requested review from
ChrisMattew,
gispada and
freddi301
as code owners
November 21, 2024 15:13
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOAPPX-346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Can cause runtime errors which crash the app, tests are very important.
Short description
This PR removes manually linked dependencies as they should support autolinking. Mostly Android.
List of changes proposed in this pull request
How to test
To avoid runtime crashes due to improperly linked libraries, I'm adding a test for each removed dependency, unless not declared anymore, as an extra precaution. Tests are only required on Android unless specified otherwise. Clean the project before starting the tests:
jail-monkey
-> Test a complete an onboarding process;react-native-linear-gradient
-> TestIOScrollView.tsx
by navigating toProfile -> Design System -> IOScrollView
;react-native-share
-> Try to share a payment receipt. The system share menu should pop up and you should be able to share the document;react-native-fingerprint-scanner
-> Enable the fingering during the onboarding and test a login by using it;react-native-reanimated
-> Test animated pictograms by navigating toProfile -> Design System -> Animated Pictograms
;react-native-cookies/cookies
-> Test a CIE login on Android;react-native-view-shot
-> This is currently only used in EuCovid related dead code but explicitly supports autolinking so it should be fine;react-native-image-picker
-> Try to select an image from theScan
->Load
section of the app. The image picker should pop up;react-native-flag-secure-android
-> Unsure about this one;react-native-fs
-> Test the download from a message with attachments or enable the FCI inio-dev-api-server
with the flagfci: { fci: { waitForSignatureCount: 1 } }
and try to open a document during the signing flow. The app should download it and show it;react-native-android-open-settings
-> OpenProfile -> Preferences -> Favourite Calendar
and deny the access to the calendar. Press againFavourite Calendar
and thenEnable access
. The app should open the Android settings;react-native-calendar-events
-> Withio-dev-api-server
enable the flagmessages: { paymentWithValidDueDateCount: 1 }
, open the message and you should be able to add a reminder to your calendar;react-native-background-timer
-> Type the identification pin wrongly until a blocking timer is shown;react-native-svg
-> OpenProfile -> Design System -> Loaders
and check if the loaders are displayed;react-native-splash-screen
-> The app splash screen should be properly displayed;react-native-exception-handler
-> This can be tested by throwing an unhandled exception in bundle mode. An alert should be shown. This might be tricky to test.react-native-push-notification
-> Test a notification;react-native-keychain
-> Test the onboarding process as it's used to store the citizen PIN;react-native-i18n
-> Try to change the app language;react-native-mixpanel
-> The app should still send events to Mixpanel;react-native-device-info
-> The app version number in theProfile
section should be shown;react-native-config
-> Start the app with the local/production environment;react-native-screen-brightness
-> OpenProfile -> Your Data
and pressShown
in the fiscal code section. The brightness of the device should change;react-native-art
-> Same asreact-native-screen-brightness
, the fiscal code barcode should be shown. Test this on iOS too.Please test any critical flow which comes to your mind as well.