Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1862] Remove transparent header within credential details screen #6418

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mastro993
Copy link
Contributor

Short description

This PR removes the header transparency within credential details screen

List of changes proposed in this pull request

  • Removed transparent: true prop from useHeaderSecondLevel
  • Removed header images for TS credential
  • Removed extra top margins from details screens

How to test

Navigate to the credential details screen, check that everything is rendered correctly.

Preview

@pagopa-github-bot pagopa-github-bot changed the title [SIW-1862] Remove transparent header within credential details screen chore(IT Wallet): [SIW-1862] Remove transparent header within credential details screen Nov 19, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 19, 2024

Affected stories

  • ⚙️ SIW-1862: [io-app] Rimozione trasparenza header in schermata dettaglio patente

Generated by 🚫 dangerJS against bc02877

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.72%. Comparing base (4f204b4) to head (bc02877).
Report is 748 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6418      +/-   ##
==========================================
- Coverage   48.42%   47.72%   -0.71%     
==========================================
  Files        1488     1607     +119     
  Lines       31617    32256     +639     
  Branches     7669     7405     -264     
==========================================
+ Hits        15311    15394      +83     
- Misses      16238    16820     +582     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
...tation/components/ItwPresentationDetailsHeader.tsx 26.66% <ø> (ø)
...on/components/ItwPresentationDetailsScreenBase.tsx 17.24% <ø> (ø)

... and 1662 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a3734...bc02877. Read the comment docs.

---- 🚨 Try these New Features:

@gispada
Copy link
Collaborator

gispada commented Nov 19, 2024

This is what I get on Android:

@mastro993 mastro993 self-assigned this Nov 20, 2024
@mastro993
Copy link
Contributor Author

mastro993 commented Nov 21, 2024

This is what I get on Android:

Quite strange! Did you try to run a yarn install before trying this PR? This change requires io-app-design-system version 3.0.1+.
The change was introduced here: pagopa/io-app-design-system#355

@gispada
Copy link
Collaborator

gispada commented Nov 21, 2024

Quite strange! Did you try to run a yarn install before trying this PR? This change requires io-app-design-system version 3.0.1+. The change was introduced here: pagopa/io-app-design-system#355

My bad: I didn't update the design system.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit 08650b1 into master Nov 21, 2024
13 checks passed
@mastro993 mastro993 deleted the SIW-1862-remove-transparent-header branch November 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants