Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-422] Replace the legacy markdown renderer with IOMarkdown #6445

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from

Merge branch 'master' into IOAPPX-422-IOMarkdown

3112c97
Select commit
Loading
Failed to load commit list.
Draft

chore(Cross): [IOAPPX-422] Replace the legacy markdown renderer with IOMarkdown #6445

Merge branch 'master' into IOAPPX-422-IOMarkdown
3112c97
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 0s

49.20% (+0.03%) compared to a0d562f

View this Pull Request on Codecov

49.20% (+0.03%) compared to a0d562f

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 49.20%. Comparing base (a0d562f) to head (3112c97).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/components/IOMarkdown/customRules.tsx 21.42% 11 Missing ⚠️
...ces/details/components/CardWithMarkdownContent.tsx 0.00% 3 Missing ⚠️
...omponents/detail/eyca/EycaInformationComponent.tsx 50.00% 2 Missing ⚠️
...us/common/components/BonusInformationComponent.tsx 0.00% 1 Missing ⚠️
...pay/onboarding/screens/InitiativeDetailsScreen.tsx 0.00% 1 Missing ⚠️
...eatures/messages/saga/handleMessagePrecondition.ts 0.00% 1 Missing ⚠️
...le/components/services/ManualConfigBottomSheet.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6445      +/-   ##
==========================================
+ Coverage   49.17%   49.20%   +0.03%     
==========================================
  Files        1554     1547       -7     
  Lines       32069    31775     -294     
  Branches     7265     7175      -90     
==========================================
- Hits        15769    15634     -135     
+ Misses      16261    16102     -159     
  Partials       39       39
Files with missing lines Coverage Δ
ts/components/ui/LoadingSkeleton.tsx 33.33% <ø> (ø)
ts/components/ui/Markdown/handlers/link.ts 100.00% <ø> (+32.14%) ⬆️
ts/components/ui/Markdown/script.ts 100.00% <ø> (ø)
ts/features/fci/hooks/useFciAbortSignatureFlow.tsx 61.11% <ø> (ø)
...s/fims/singleSignOn/components/FimsPrivacyInfo.tsx 20.00% <ø> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 9.09% <ø> (ø)
...dpay/details/components/InitiativeRulesInfoBox.tsx 30.00% <ø> (ø)
...rding/components/OnboardingDescriptionMarkdown.tsx 33.33% <ø> (+19.04%) ⬆️
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 9.52% <ø> (ø)
...let/identification/screens/cie/ItwCiePinScreen.tsx 15.15% <ø> (ø)
... and 19 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d562f...3112c97. Read the comment docs.

View more details on Codecov