Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPLT-801] Improvements to canary release workflow #6468

Merged
merged 28 commits into from
Dec 18, 2024

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Nov 27, 2024

Short description

This PR aims to improve canary release workflow.

List of changes proposed in this pull request

  • Avoid commit and push of temporary canary setup
  • Create and push to origin only the canary tag
  • removes bash scripts to rename app package
  • uses build variants on both iOS and Android app configuration.

How to test

Static check the workflow file / test a run changing the trigger

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 27, 2024

Affected stories

  • ⚙️ IOPLT-801: Utilizzare le build variants di iOS e i flavors di gradle per la build e distribuzione della Canary release di IO

Generated by 🚫 dangerJS against 62fd4f2

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (4f204b4) to head (9abb347).
Report is 907 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6468      +/-   ##
==========================================
+ Coverage   48.42%   49.16%   +0.74%     
==========================================
  Files        1488     1554      +66     
  Lines       31617    32067     +450     
  Branches     7669     7309     -360     
==========================================
+ Hits        15311    15767     +456     
- Misses      16238    16261      +23     
+ Partials       68       39      -29     

see 1739 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9df54...9abb347. Read the comment docs.

@pagopa-github-bot pagopa-github-bot changed the title [IOPLT-801] Improvements to canary release workflow chore: [IOPLT-801] Improvements to canary release workflow Dec 12, 2024
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPLT-801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants