Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-444] Remove legacy components from the DS #6475

Merged
merged 8 commits into from
Dec 1, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Nov 29, 2024

Short description

This PR removes legacy components not used anymore in active projects.

List of changes proposed in this pull request

  • Remove IOBadge by replacing its remaining instances with Badge from DS
  • Remove CopyButtonComponent by replacing remaining instances with ListItemInfoCopy from DS
  • Remove unused CustomBadge
  • Remove BlockButtons references
  • Remove DSLegacyButtons
  • Remove DSLegacyAlert
  • Remove DSLegacyBadges

How to test

Check all the screens involved in the refactoring and test if everything is OK

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed labels Nov 29, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-444] Remove legacy components from the DS chore(Cross): [IOAPPX-444] Remove legacy components from the DS Nov 29, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 29, 2024

Affected stories

  • ⚙️ IOAPPX-444: Rimozione dei componenti legacy del DS
    subtask of

Generated by 🚫 dangerJS against 86ab827

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 47.70%. Comparing base (4f204b4) to head (86ab827).
Report is 808 commits behind head on master.

Files with missing lines Patch % Lines
...line/components/TimelineRefundDetailsComponent.tsx 0.00% 4 Missing ⚠️
...components/TimelineTransactionDetailsComponent.tsx 0.00% 4 Missing ⚠️
...res/bonus/common/components/AvailableBonusItem.tsx 0.00% 2 Missing ⚠️
ts/features/fci/hooks/useFciAbortSignatureFlow.tsx 0.00% 2 Missing ⚠️
...ts/TimelineDiscountTransactionDetailsComponent.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6475      +/-   ##
==========================================
- Coverage   48.42%   47.70%   -0.73%     
==========================================
  Files        1488     1577      +89     
  Lines       31617    32265     +648     
  Branches     7669     7355     -314     
==========================================
+ Hits        15311    15392      +81     
- Misses      16238    16832     +594     
+ Partials       68       41      -27     
Files with missing lines Coverage Δ
ts/components/screens/ListItemComponent.tsx 10.00% <ø> (-68.58%) ⬇️
ts/components/ui/TabIconComponent.tsx 33.33% <ø> (+8.33%) ⬆️
ts/features/bonus/cdc/components/CdcServiceCTA.tsx 86.00% <ø> (-2.00%) ⬇️
ts/features/design-system/navigation/navigator.tsx 17.64% <ø> (-5.22%) ⬇️
ts/features/design-system/navigation/routes.ts 100.00% <ø> (ø)
...res/bonus/common/components/AvailableBonusItem.tsx 15.78% <0.00%> (-3.26%) ⬇️
ts/features/fci/hooks/useFciAbortSignatureFlow.tsx 61.11% <0.00%> (-3.89%) ⬇️
...ts/TimelineDiscountTransactionDetailsComponent.tsx 11.11% <0.00%> (-0.66%) ⬇️
...line/components/TimelineRefundDetailsComponent.tsx 10.00% <0.00%> (ø)
...components/TimelineTransactionDetailsComponent.tsx 11.76% <0.00%> (-2.53%) ⬇️

... and 1691 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c8b4f...86ab827. Read the comment docs.

@dmnplb dmnplb merged commit d3660d3 into master Dec 1, 2024
12 checks passed
@dmnplb dmnplb deleted the IOAPPX-444-remove-legacy-components-from-DS branch December 1, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants