-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-444] Remove legacy components from the DS #6475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
Design System
New visual language and reduction of previous UI clutter
💀 Dead matter
Graphic assets or chunks of code that are no longer referenced or needed
labels
Nov 29, 2024
pagopa-github-bot
changed the title
[IOAPPX-444] Remove legacy components from the DS
chore(Cross): [IOAPPX-444] Remove legacy components from the DS
Nov 29, 2024
Affected stories
|
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
November 29, 2024 15:53
mastro993
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cross
💀 Dead matter
Graphic assets or chunks of code that are no longer referenced or needed
Design System
New visual language and reduction of previous UI clutter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes legacy components not used anymore in active projects.
List of changes proposed in this pull request
IOBadge
by replacing its remaining instances withBadge
from DSCopyButtonComponent
by replacing remaining instances withListItemInfoCopy
from DSCustomBadge
BlockButtons
referencesDSLegacyButtons
DSLegacyAlert
DSLegacyBadges
How to test
Check all the screens involved in the refactoring and test if everything is OK