Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOCOM-1994,IOCOM-1995] Fix for back behaviours on FIMS Auth #6481

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR fixes some anomalies on the back behaviour for the FIMS' Auth flow

List of changes proposed in this pull request

  • When going back from an error screen, proper deallocation of FIMS resources was not triggered (using navigation.back instead of back saga)
  • On Android, physical back button event is not handled by the assistance modal and is propagated to the underlying screen. If this happens on the FIMS' consents screen, the flow is interrupted. Since this anomaly affects the entire app, the back capturing has been disabled and the user has to rely on the UI back buttons

How to test

Using the io-dev-api-server, check that:

  • the FIMS flow can be successfully retried after an error
  • the Android back button does nothing on the FIMS' Auth flow

… screen

Fix for error screen not deallocating FIMS resources when going back
@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1994,IOCOM-1995] Fix for back behaviours on FIMS Auth fix: [IOCOM-1994,IOCOM-1995] Fix for back behaviours on FIMS Auth Dec 2, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 2, 2024

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • 🐞 IOCOM-1994: [FIMS] Spinner infinito dopo back da FAQ
  • 🐞 IOCOM-1995: [FIMS] Errore dopo ripristino connessione dati persa durante spinner dopo consenso

Generated by 🚫 dangerJS against d8da83a

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.30%. Comparing base (4f204b4) to head (d8da83a).
Report is 831 commits behind head on master.

Files with missing lines Patch % Lines
...s/singleSignOn/components/FimsFullScreenErrors.tsx 0.00% 3 Missing ⚠️
...ims/singleSignOn/screens/FimsFlowHandlerScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
- Coverage   48.42%   48.30%   -0.13%     
==========================================
  Files        1488     1578      +90     
  Lines       31617    32265     +648     
  Branches     7669     7389     -280     
==========================================
+ Hits        15311    15585     +274     
- Misses      16238    16625     +387     
+ Partials       68       55      -13     
Files with missing lines Coverage Δ
...ims/singleSignOn/screens/FimsFlowHandlerScreen.tsx 2.85% <0.00%> (ø)
...s/singleSignOn/components/FimsFullScreenErrors.tsx 5.55% <0.00%> (ø)

... and 1714 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbaa6c...d8da83a. Read the comment docs.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit e05a6a3 into master Dec 4, 2024
12 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1994-1995 branch December 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants