fix: [IOPID-2547] Fix unhandled error on Linking.openUrl
#6554
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Linking.openUrlLinking.openUrl
Affected stories
|
ChrisMattew
added
IO-A&I
CrisTofani
reviewed
Dec 16, 2024
| @@ -36,7 +38,9 @@ const CieIdNotInstalled = ({ isUat }: CieIdNotInstalledProps) => { | |||
| android: isUat ? CIE_ID_ANDROID_COLL_LINK : CIE_ID_ANDROID_LINK, | |||
| default: "" | |||
| }) | |||
| ); | |||
| ).catch(() => { | |||
ChrisMattew
requested review from
thisisjp,
gispada,
freddi301 and
a team
as code owners
|
@mariateresaventura copy review needed! 🙏🏻 |
mariateresaventura
had a problem deploying
to
dev
GitHub Actions
Error
mariateresaventura
temporarily deployed
to
dev
GitHub Actions
Inactive
mariateresaventura
removed
the
copy review needed ✋🏼 🖊️
Done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6554 +/- ##
==========================================
+ Coverage 48.42% 49.28% +0.86%
==========================================
Files 1488 1553 +65
Lines 31617 31986 +369
Branches 7669 7288 -381
==========================================
+ Hits 15311 15765 +454
+ Misses 16238 16182 -56
+ Partials 68 39 -29
... and 1737 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR handles any potential errors when attempting to open the store using
Linking.openUrl.List of changes proposed in this pull request
toast messageto notify the user of the error in case the store cannot be opened.Screen