Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-810] Enable allowFontScaling by default for all citizens #6561

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[IOPLT-810] Enable allowFontScaling by default for all citizens #6561

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e9196a7
Enable `allowFontScaling` by default for all citizens
dmnplb Dec 17, 2024
03fd7a8
Minor refactoring to fix TS issues
dmnplb Dec 18, 2024
49765bb
Remove `Itw` deprecated component to fix TS issue
dmnplb Dec 18, 2024
d1d3ebe
Update `io-app-design-system` to `4.4.1`
dmnplb Dec 18, 2024
b74b23f
Update `jest` snapshots
dmnplb Dec 18, 2024
f54c8d1
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
dmnplb Dec 18, 2024
44c62aa
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
LeleDallas Dec 19, 2024
2e0bdde
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
LeleDallas Dec 19, 2024
b0656d1
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
LeleDallas Dec 19, 2024
555876e
Fix visual issue in the Cgn categories list
dmnplb Dec 19, 2024
7ece3ea
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
dmnplb Dec 19, 2024
02b6a2d
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
LeleDallas Dec 20, 2024
28ba1aa
Merge branch 'master' into IOPLT-810-set-allow-font-scaling-to-true-b…
dmnplb Dec 20, 2024
3e0aff9
Update `io-app-design-system` to `4.4.2`
dmnplb Dec 20, 2024
116782c
Update `io-app-design-system` to `4.4.3`
dmnplb Dec 20, 2024
498644c
Update `jest` snapshots
dmnplb Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
},
"dependencies": {
"@gorhom/bottom-sheet": "^4.1.5",
"@pagopa/io-app-design-system": "4.3.0",
"@pagopa/io-app-design-system": "4.4.1",
"@pagopa/io-pagopa-commons": "^3.1.0",
"@pagopa/io-react-native-cieid": "^0.3.5",
"@pagopa/io-react-native-crypto": "^1.0.1",
Expand Down
84 changes: 42 additions & 42 deletions ts/components/__tests__/__snapshots__/IOMarkdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
exports[`IOMarkdown Should match snapshot 1`] = `
<View>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="largeTitle"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand All @@ -30,9 +30,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title1"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand All @@ -57,9 +57,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -104,9 +104,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -168,9 +168,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -208,9 +208,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -238,9 +238,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -278,9 +278,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -308,9 +308,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -348,9 +348,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -387,9 +387,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -451,9 +451,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -492,9 +492,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -522,9 +522,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -563,9 +563,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -593,9 +593,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -634,9 +634,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -673,9 +673,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand All @@ -693,9 +693,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
Here is a link:
<Text
accessibilityRole="link"
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
onPress={[Function]}
style={
[
Expand Down Expand Up @@ -724,9 +724,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -768,9 +768,9 @@ exports[`IOMarkdown Should match snapshot 1`] = `
}
/>
<Text
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="body"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down
15 changes: 9 additions & 6 deletions ts/components/__tests__/__snapshots__/LoadingSpinnerOverlay.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,9 @@ exports[`LoadingSpinnerOverlay Should match all-properties and loading snapshot
>
<Text
accessible={true}
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -315,6 +315,9 @@ exports[`LoadingSpinnerOverlay Should match all-properties and loading snapshot
{
"height": 40,
},
{
"columnGap": 8,
},
false,
{
"backgroundColor": "rgba(0,115,230,0)",
Expand All @@ -331,10 +334,10 @@ exports[`LoadingSpinnerOverlay Should match all-properties and loading snapshot
<Text
accessibilityElementsHidden={true}
accessible={false}
allowFontScaling={false}
allowFontScaling={true}
ellipsizeMode="tail"
importantForAccessibility="no-hide-descendants"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
numberOfLines={1}
style={
[
Expand Down Expand Up @@ -639,9 +642,9 @@ exports[`LoadingSpinnerOverlay Should match base loading snapshot 1`] = `
>
<Text
accessible={true}
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down
4 changes: 2 additions & 2 deletions ts/components/__tests__/__snapshots__/WebviewComponent.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,9 @@ exports[`WebviewComponent tests snapshot for component 1`] = `
>
<Text
accessible={true}
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down
16 changes: 8 additions & 8 deletions ts/components/screens/__tests__/__snapshots__/LoadingScreenContent.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,9 +559,9 @@ exports[`LoadingScreenContent should match the snapshot with title, a child, hea
</View>
<Text
accessibilityLabel="Test Content Title"
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -1159,9 +1159,9 @@ exports[`LoadingScreenContent should match the snapshot with title, a child, hea
</View>
<Text
accessibilityLabel="Test Content Title"
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -1759,9 +1759,9 @@ exports[`LoadingScreenContent should match the snapshot with title, no children,
</View>
<Text
accessibilityLabel="Test Content Title"
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down Expand Up @@ -2356,9 +2356,9 @@ exports[`LoadingScreenContent should match the snapshot with title, no children,
</View>
<Text
accessibilityLabel="Test Content Title"
allowFontScaling={false}
allowFontScaling={true}
dynamicTypeRamp="title2"
maxFontSizeMultiplier={1.25}
maxFontSizeMultiplier={1.5}
style={
[
{},
Expand Down
Loading
Loading