Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPX-405] Removing unused react imports #6562

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updates the ESLint and Babel configurations, along with package dependencies, to support the latest version of the JSX transform. This new transform enable the use of JSX without importing React.

List of changes proposed in this pull request

  • Apply changes as described in official documentation here

How to test

Ensure that the application works as expected, without any compilation errors or runtime crashes

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOAPPX-405

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 53.40909% with 82 lines in your changes missing coverage. Please review.

Project coverage is 49.24%. Comparing base (fbe9e87) to head (b7be7d4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...atures/barcode/hooks/useIOBarcodeCameraScanner.tsx 0.00% 9 Missing ⚠️
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 0.00% 6 Missing ⚠️
ts/components/ui/LightModal.tsx 28.57% 5 Missing ⚠️
...n/screens/merchants/CgnMerchantsListByCategory.tsx 0.00% 5 Missing ⚠️
ts/features/design-system/core/DSNumberPad.tsx 0.00% 5 Missing ⚠️
...us/common/components/BonusInformationComponent.tsx 0.00% 4 Missing ⚠️
...components/cie/CieRequestAuthenticationOverlay.tsx 25.00% 3 Missing ⚠️
...ures/bonus/common/components/TosBonusComponent.tsx 25.00% 3 Missing ⚠️
ts/features/design-system/core/DSTextFields.tsx 0.00% 3 Missing ⚠️
ts/components/bottomSheet/BottomSheetHeader.tsx 33.33% 2 Missing ⚠️
... and 28 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6562      +/-   ##
==========================================
+ Coverage   42.85%   49.24%   +6.38%     
==========================================
  Files        1408     1555     +147     
  Lines       29557    32092    +2535     
  Branches     6659     7266     +607     
==========================================
+ Hits        12668    15803    +3135     
+ Misses      16860    16251     -609     
- Partials       29       38       +9     
Files with missing lines Coverage Δ
ts/components/AnimatedImage.tsx 83.33% <ø> (ø)
ts/components/AppVersion.tsx 100.00% <ø> (+60.00%) ⬆️
ts/components/BonusCard/BonusCard.tsx 93.93% <100.00%> (ø)
ts/components/BonusCard/BonusCardCounter.tsx 92.00% <100.00%> (ø)
.../components/BonusCard/BonusCardScreenComponent.tsx 100.00% <ø> (ø)
ts/components/BonusCard/BonusCardShape.tsx 81.81% <ø> (ø)
ts/components/BonusCard/BonusCardStatus.tsx 92.30% <ø> (ø)
ts/components/BulletList.tsx 71.42% <ø> (ø)
ts/components/CalendarList.tsx 20.00% <ø> (ø)
ts/components/Carousel.tsx 88.23% <ø> (ø)
... and 237 more

... and 527 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a835a70...b7be7d4. Read the comment docs.

@LeleDallas
Copy link
Contributor Author

LGTM! Tested on both iOS and Android

Thanks for reviewing it!

Let's wait someone else double check before merging it💪

# Conflicts:
#	ts/features/cie/components/CieIdNotInstalled.tsx
#	ts/features/design-system/core/DSListItems.tsx
#	ts/features/design-system/core/DSModules.tsx
#	ts/features/messages/components/Home/DS/CustomPressableListItemBase.tsx
#	ts/features/messages/components/Home/DS/ListItemMessageSkeleton.tsx
#	ts/features/messages/components/Home/DS/MessageListItem.tsx
#	ts/features/messages/components/Home/Footer.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants