Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ffi version mismatch on linux environment #6563

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR fixes an issue on android release workflow

see ffi/ffi#1103 (comment)

Copy link
Contributor

Jira Pull request Link

It seems this Pull Request has no issues that refers to Jira!!!
Please check it out.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (4f204b4) to head (759b46b).
Report is 900 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6563      +/-   ##
==========================================
+ Coverage   48.42%   49.25%   +0.82%     
==========================================
  Files        1488     1553      +65     
  Lines       31617    31983     +366     
  Branches     7669     7240     -429     
==========================================
+ Hits        15311    15752     +441     
+ Misses      16238    16192      -46     
+ Partials       68       39      -29     

see 1738 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59a660...759b46b. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisTofani CrisTofani merged commit 082241e into master Dec 18, 2024
8 of 9 checks passed
@CrisTofani CrisTofani deleted the fix-ffi-dependency branch December 18, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants