Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-2566] Refactor AuthErrorComponent #6565

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChrisMattew
Copy link
Collaborator

Short description

Include a summary of the changes.

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

… params and move spid request states on redux
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2566

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 31.11111% with 31 lines in your changes missing coverage. Please review.

Project coverage is 49.16%. Comparing base (4f204b4) to head (0e30587).
Report is 907 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/spidLogin/store/reducers/index.ts 41.17% 10 Missing ⚠️
ts/screens/authentication/AuthErrorScreen.tsx 0.00% 7 Missing ⚠️
ts/screens/authentication/IdpLoginScreen.tsx 0.00% 7 Missing ⚠️
...s/screens/authentication/idpAuthSessionHandler.tsx 0.00% 5 Missing ⚠️
ts/features/spidLogin/store/selectors/index.ts 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6565      +/-   ##
==========================================
+ Coverage   48.42%   49.16%   +0.73%     
==========================================
  Files        1488     1557      +69     
  Lines       31617    32099     +482     
  Branches     7669     7273     -396     
==========================================
+ Hits        15311    15781     +470     
- Misses      16238    16279      +41     
+ Partials       68       39      -29     
Files with missing lines Coverage Δ
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/spidLogin/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/spidLogin/store/selectors/index.ts 50.00% <50.00%> (ø)
...s/screens/authentication/idpAuthSessionHandler.tsx 4.38% <0.00%> (-0.29%) ⬇️
ts/screens/authentication/AuthErrorScreen.tsx 9.52% <0.00%> (ø)
ts/screens/authentication/IdpLoginScreen.tsx 1.86% <0.00%> (-2.14%) ⬇️
ts/features/spidLogin/store/reducers/index.ts 41.17% <41.17%> (ø)

... and 1735 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9df54...0e30587. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant