-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1934] Cleanup the integrityKeyTag if getWalletAttestation throws an error #6569
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1934 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6569 +/- ##
==========================================
+ Coverage 48.42% 49.16% +0.73%
==========================================
Files 1488 1554 +66
Lines 31617 32069 +452
Branches 7669 7264 -405
==========================================
+ Hits 15311 15767 +456
- Misses 16238 16262 +24
+ Partials 68 40 -28
... and 1736 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…into siw-1934-integrity-key-clenaup
Short description
This PR updates the
WalletInstanceAttestationObtainment
machine step adding a cleanup function if there is an error.List of changes proposed in this pull request
getWalletAttestation
throws an errorHow to test
Ensure that, when creating a WI, after an error on the
WalletInstanceAttestationObtainment
step, theIntegrityKeyTag
has been correctly deleted, and a new key is generated when retrying to create a WI.