Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-681] fixed query param decode in get third party attachments url #1074

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[#IOCOM-681] fixed query param decode in get third party attachments url #1074

merged 2 commits into from
Nov 22, 2023

Conversation

acuiuli
Copy link
Contributor

@acuiuli acuiuli commented Nov 22, 2023 •
edited
Loading

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@acuiuli acuiuli requested a review from a team as a code owner November 22, 2023 10:17
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-681

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

michaeldisaro
michaeldisaro approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuiuli acuiuli merged commit 3313bb5 into master Nov 22, 2023
6 checks passed
@acuiuli acuiuli deleted the fix-query-param-attachments-url branch November 22, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

@giuseppedipinto giuseppedipinto Awaiting requested review from giuseppedipinto giuseppedipinto is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acuiuli @michaeldisaro