Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1201] Disable notifications when the user locks the session from ioapp.it #1080

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[#IOPID-1201] Disable notifications when the user locks the session from ioapp.it #1080

merged 4 commits into from
Dec 12, 2023

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • add deleteInstallation to lockUserAuthentiction flow](fa4308d)
  • add tests](d6eacbd)

Motivation and Context

Avoid to sent notifications to the user's device when a session lock occurred

How Has This Been Tested?

Unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati requested a review from a team as a code owner December 11, 2023 11:49
@gquadrati gquadrati requested review from acuiuli and Garma00 December 11, 2023 11:49
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1201

arcogabbo
arcogabbo approved these changes Dec 11, 2023
View reviewed changes
src/controllers/sessionLockController.ts Outdated Show resolved Hide resolved
@gquadrati @arcogabbo
Update src/controllers/sessionLockController.ts
aac41c7 
Co-authored-by: Gabriele Mendolia <arcogabbo@gmail.com>
BurnedMarshal
BurnedMarshal approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/controllers/sessionLockController.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati merged commit a406e4a into master Dec 12, 2023
6 checks passed
@gquadrati gquadrati deleted the IOPID-1201 branch December 12, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@acuiuli acuiuli Awaiting requested review from acuiuli acuiuli is a code owner automatically assigned from pagopa/io-backend-contributors

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gquadrati @BurnedMarshal @arcogabbo