Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#IOPID-1269] Return error type from fn-app #1089

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: [#IOPID-1269] Return error type from fn-app #1089

merged 1 commit into from
Dec 19, 2023

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • Return error type from fn-app

Motivation and Context

Bugfix: when 412 is returned, the app needs the type returned from fn-app

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati requested a review from a team as a code owner December 19, 2023 11:04
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1269

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

BurnedMarshal
BurnedMarshal approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arcogabbo
arcogabbo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@BurnedMarshal BurnedMarshal merged commit 079803b into master Dec 19, 2023
5 checks passed
@BurnedMarshal BurnedMarshal deleted the IOPID-1269 branch December 19, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@rodoviti rodoviti Awaiting requested review from rodoviti rodoviti is a code owner automatically assigned from pagopa/io-backend-contributors

@acuiuli acuiuli Awaiting requested review from acuiuli acuiuli is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gquadrati @BurnedMarshal @arcogabbo