Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1453] Add event for Zendesk jwt errors #1101

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[#IOPID-1453] Add event for Zendesk jwt errors #1101

merged 1 commit into from
Feb 1, 2024

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • Trigger new appbackend.zendesk.error custom event

Motivation and Context

Raise an event when an error occurred on Zendesk token generation endpoint

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1453

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gquadrati gquadrati marked this pull request as ready for review February 1, 2024 09:53
@gquadrati gquadrati requested a review from a team as a code owner February 1, 2024 09:53
@gquadrati gquadrati requested review from balanza and drmarro February 1, 2024 09:53
BurnedMarshal
BurnedMarshal approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some minor comments

src/controllers/zendeskController.ts Show resolved Hide resolved
src/app.ts Show resolved Hide resolved
@gquadrati gquadrati merged commit 3195234 into master Feb 1, 2024
5 checks passed
@gquadrati gquadrati deleted the IOPID-1453 branch February 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@balanza balanza Awaiting requested review from balanza balanza is a code owner automatically assigned from pagopa/io-backend-contributors

@drmarro drmarro Awaiting requested review from drmarro drmarro is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gquadrati @BurnedMarshal @arcogabbo