-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IOPID-1603] added new HTML static page #1105
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-1603 |
a85efb6
to
c4b3565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a minor comment. Feel free to merge without addressing it.
public/email_confirm.html
Outdated
const token = url.searchParams.get("token"); | ||
|
||
if (email && token) { | ||
$("#bold-email").text(base64UrlDecode(email)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this scenario is not expected to occur, I would prefer to return the error message in the event of a decoding failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice point, I addressed it in 61b1d4a
Quality Gate passedIssues Measures |
href
(c4b3565)List of Changes
Motivation and Context
add new page for email validation confirm
How Has This Been Tested?
local tests
Screenshots (if appropriate):
Types of changes
Checklist: