Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-1603] added new HTML static page #1105

Merged
merged 3 commits into from
Feb 28, 2024
Merged

[#IOPID-1603] added new HTML static page #1105

merged 3 commits into from
Feb 28, 2024

Conversation

arcogabbo
Copy link
Contributor

@arcogabbo arcogabbo commented Feb 26, 2024

  • TODO: remove local reference on cta href (c4b3565)

List of Changes

Motivation and Context

add new page for email validation confirm

How Has This Been Tested?

local tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1603

@arcogabbo arcogabbo marked this pull request as ready for review February 28, 2024 10:30
@arcogabbo arcogabbo requested a review from a team as a code owner February 28, 2024 10:30
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment. Feel free to merge without addressing it.

const token = url.searchParams.get("token");

if (email && token) {
$("#bold-email").text(base64UrlDecode(email));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this scenario is not expected to occur, I would prefer to return the error message in the event of a decoding failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice point, I addressed it in 61b1d4a

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arcogabbo arcogabbo merged commit 7d107ef into master Feb 28, 2024
5 checks passed
@arcogabbo arcogabbo deleted the IOPID-1603 branch February 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants