Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPAE-1096]Add openapi definition for new services APIs #1109

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

giamma1295
Copy link
Contributor

@giamma1295 giamma1295 commented Apr 12, 2024

List of Changes

  • Add new services APIs OpenApi template io-services-app-backend.template.yaml
  • Add new generation command generate:api:services-app-backend in package.json, this will generate all schemas and client in order to call the new services APIs exposed by the io-services-app-backend Azure Function App.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-1096

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@giamma1295 giamma1295 changed the title WIP:[#IOPAE-1096]Add openapi definition for new services APIs [#IOPAE-1096]Add openapi definition for new services APIs Apr 18, 2024
@giamma1295 giamma1295 marked this pull request as ready for review April 18, 2024 16:04
@giamma1295 giamma1295 requested a review from a team as a code owner April 18, 2024 16:04
@giuseppedipinto giuseppedipinto merged commit a814a30 into master Apr 19, 2024
8 checks passed
@giuseppedipinto giuseppedipinto deleted the IOPAE-1096-add-services-app-backend-openapi branch April 19, 2024 11:11
@gunzip
Copy link
Contributor

gunzip commented Apr 20, 2024

Are we sure we don't need to output ProblemJson in case of HTTP 500? ie. https://github.com/pagopa/io-backend/blob/master/api_notifications.yaml#L65

@gunzip
Copy link
Contributor

gunzip commented Apr 20, 2024

Consider 502 and 504 http status as well. https://github.com/pagopa/io-backend/blob/master/api_io_sign.yaml#L97

@gunzip
Copy link
Contributor

gunzip commented Apr 20, 2024

I guess you also need to add a security section: https://github.com/pagopa/io-backend/blob/master/api_io_sign.yaml#L7

adelloste added a commit to pagopa/io-app that referenced this pull request Apr 23, 2024
…tions in the services section (#5701)

This pr depends on pagopa/io-backend#1109,
pagopa/io-backend#1115

## Short description
This PR adds a new reducer and selectors to handle the list of
institutions in the services section

## List of changes proposed in this pull request
- Added home reducer, actions, and selectors
- Added tests

## How to test
Tests should be solved properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants