Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SIW-1112-1113-1114] Added getNonce, createWalletInstance, createWalletAttestation endpoints #1130

Merged
merged 12 commits into from
May 31, 2024
Merged

feat: [SIW-1112-1113-1114] Added getNonce, createWalletInstance, createWalletAttestation endpoints #1130

merged 12 commits into from
May 31, 2024

Conversation

silvicir
Copy link
Contributor

@silvicir silvicir commented May 27, 2024 •
edited
Loading

Depends on pagopa/io-infra#1001

List of Changes

  1. Added api_io_wallet.yaml openapi
  2. Added /nonce, /wallet-instances and /token endpoints
  3. Updated IoWalletController and IoWalletService
  4. Added unit tests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1112-1113-1114

@silvicir silvicir marked this pull request as ready for review May 27, 2024 14:48
@silvicir silvicir requested a review from a team as a code owner May 27, 2024 14:48
@silvicir silvicir requested review from Garma00 and StefanoDoc May 27, 2024 14:48
@silvicir silvicir requested a review from grausof May 27, 2024 15:30
gunzip
gunzip reviewed May 27, 2024
View reviewed changes
src/controllers/ioWalletController.ts Outdated Show resolved Hide resolved
src/controllers/ioWalletController.ts Outdated Show resolved Hide resolved
src/controllers/ioWalletController.ts Outdated Show resolved Hide resolved
src/controllers/ioWalletController.ts Outdated Show resolved Hide resolved
gunzip
gunzip reviewed May 27, 2024
View reviewed changes
src/services/ioWalletService.ts Outdated Show resolved Hide resolved
src/services/ioWalletService.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

grausof
grausof approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since it introduces environment variables I recommend you insert a dependency of this PR on the PR towards io-infra. In such a way as to merge it only with the updated infra.

@silvicir silvicir changed the title feat: [SIW-1112-1113-1114] added getNonce, createWalletInstance, createWalletAttestation endpoints feat: [SIW-1112-1113-1114] Added getNonce, createWalletInstance, createWalletAttestation endpoints May 29, 2024
@dpulls dpulls
Copy link

dpulls bot commented May 31, 2024

🎉 All dependencies have been resolved !

@silvicir silvicir merged commit 72a48b1 into master May 31, 2024
8 checks passed
@silvicir silvicir deleted the SIW-1112-1113-1114-add-wallet-endpoints branch May 31, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunzip gunzip gunzip left review comments

@grausof grausof grausof approved these changes

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc StefanoDoc is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvicir @gunzip @grausof