Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yaml #1137

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Update config.yaml #1137

merged 1 commit into from
Jul 8, 2024

Conversation

rodoviti
Copy link
Contributor

@rodoviti rodoviti commented Jul 8, 2024

move services app backend alerts to quarantine to avoid spam on io_status_prod_error channel

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

move services app backend alerts to quarantine
@rodoviti rodoviti requested a review from a team as a code owner July 8, 2024 16:44
@rodoviti rodoviti requested review from lucacavallaro and Garma00 July 8, 2024 16:45
Copy link

github-actions bot commented Jul 8, 2024

Jira Pull request Link

It seems this Pull Request has no issues that refers to Jira!!!
Please check it out.

Copy link

sonarqubecloud bot commented Jul 8, 2024

Copy link

github-actions bot commented Jul 8, 2024

Terraform Plan 📖

Terraform Plan
�[0m�[1mInitializing the backend...�[0m
�[0m�[32m
Successfully configured the backend "azurerm"! Terraform will automatically
use this backend unless the backend configuration changes.�[0m

�[0m�[1mInitializing provider plugins...�[0m
- Finding hashicorp/azurerm versions matching ">= 3.30.0, <= 3.40.0"...
- Installing hashicorp/azurerm v3.40.0...
- Installed hashicorp/azurerm v3.40.0 (signed by HashiCorp)

Terraform has created a lock file �[1m.terraform.lock.hcl�[0m to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.�[0m

�[0m�[1m�[32mTerraform has been successfully initialized!�[0m�[32m�[0m
�[0m�[32m
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.�[0m
data.azurerm_resource_group.this: Reading...
data.azurerm_resource_group.this: Read complete after 0s [id=/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # azurerm_monitor_scheduled_query_rules_alert.alarm_availability_0 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_availability_0" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_institutions"
        name                    = "io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_institutions"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_availability_1 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_availability_1" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_institutions_featured"
        name                    = "io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_institutions_featured"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_availability_2 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_availability_2" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_institutions_institutionId_services"
        name                    = "io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_institutions_institutionId_services"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_availability_3 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_availability_3" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_services_featured"
        name                    = "io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_services_featured"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_availability_4 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_availability_4" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_services_serviceId"
        name                    = "io-p-opex_iobackend_api_service_app_backend-availability @ _api_v2_services_serviceId"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_time_0 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_time_0" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_institutions"
        name                    = "io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_institutions"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_time_1 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_time_1" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_institutions_featured"
        name                    = "io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_institutions_featured"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_time_2 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_time_2" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_institutions_institutionId_services"
        name                    = "io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_institutions_institutionId_services"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_time_3 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_time_3" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_services_featured"
        name                    = "io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_services_featured"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_scheduled_query_rules_alert.alarm_time_4 will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "alarm_time_4" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Insights/scheduledQueryRules/io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_services_serviceId"
        name                    = "io-p-opex_iobackend_api_service_app_backend-responsetime @ _api_v2_services_serviceId"
        tags                    = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Enti & Servizi"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-backend"
        }
        # (13 unchanged attributes hidden)

      ~ action {
          ~ action_group = [
              - "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/ioperror",
              + "/subscriptions/EC285037-C673-4F58-B594-D7C480DA4E8B/resourceGroups/io-p-rg-common/providers/microsoft.insights/actionGroups/iopquarantineerror",
            ]
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 10 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

@StefanoDoc StefanoDoc merged commit 33a6e66 into master Jul 8, 2024
6 of 7 checks passed
@StefanoDoc StefanoDoc deleted the services-be-alerts-quarantine branch July 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants