Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SIW-1330] added /subscriptions wallet endpoint and added wallet trial system check #1139

Merged
merged 7 commits into from
Jul 12, 2024
Merged

feat: [SIW-1330] added /subscriptions wallet endpoint and added wallet trial system check #1139

merged 7 commits into from
Jul 12, 2024

Conversation

silvicir
Copy link
Contributor

@silvicir silvicir commented Jul 11, 2024 •
edited
Loading

List of Changes

  1. Added ensureUserIsAllowed check when getting the wallet user Id in createWalletInstance and createWalletAttestation

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@silvicir silvicir requested a review from a team as a code owner July 11, 2024 08:09
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1330

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

grausof
grausof approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvicir silvicir merged commit 83074a5 into master Jul 12, 2024
7 checks passed
@silvicir silvicir deleted the SIW-1330-add-wallet-endpoint branch July 12, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grausof grausof grausof approved these changes

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc StefanoDoc is a code owner automatically assigned from pagopa/io-backend-contributors

@giuseppedipinto giuseppedipinto Awaiting requested review from giuseppedipinto giuseppedipinto is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvicir @grausof