Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPAE-1478] removed getVisibleService Api call #1165

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[#IOPAE-1478] removed getVisibleService Api call #1165

merged 1 commit into from
Nov 11, 2024

Conversation

giamma1295
Copy link
Contributor

Removed unnecessary getVisibleService API call, this proxied service is now stubbed cause is no longer called in new APP version

List of Changes

Motivation and Context

How Has This Been Tested?

Unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giamma1295 giamma1295 requested a review from a team as a code owner November 5, 2024 15:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited by jira bot
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-1478

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

rodoviti
rodoviti approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@rodoviti rodoviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giamma1295 giamma1295 merged commit 05bc102 into master Nov 11, 2024
5 of 6 checks passed
@giamma1295 giamma1295 deleted the IOPAE-1478-remove-get-visible-service branch November 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodoviti rodoviti rodoviti approved these changes

@michaeldisaro michaeldisaro Awaiting requested review from michaeldisaro michaeldisaro is a code owner automatically assigned from pagopa/io-backend-contributors

@pasqualedevita pasqualedevita Awaiting requested review from pasqualedevita pasqualedevita is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giamma1295 @rodoviti